fix(build): kill chg daemon before installing #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Frequently, if I have sl running when trying to upgrade sl, I get this error during `make install-oss`: ```sh $ make install-oss ... rm -f sl cp build/scripts-3.11/sl sl mkdir -p //usr/local/bin cp sl //usr/local/bin cp: cannot create regular file '//usr/local/bin/sl': Text file busy make: *** [Makefile:99: install-oss] Error 1 ``` This diff works around the issue by killing the chg daemon before installing the new version of sl. I also added a `sleep 1` after killing the chg daemon, because I was still seeing the issue occasionally without it. I really dislike adding this sleep, so I'd appreciate any suggestions Test Plan: This happens to me about 75% of the time I try to upgrade sl, but I don't have reliable reproduction steps
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Perhaps you can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Frequently, if I have sl running when trying to upgrade sl, I get this error
during
make install-oss:This diff works around the issue by killing the chg daemon before installing
the new version of sl.
I also added a
sleep 1after killing the chg daemon, because I was stillseeing the issue occasionally without it. I really dislike adding this sleep,
so I'd appreciate any suggestions
Test Plan:
This happens to me about 75% of the time I try to upgrade sl, but I don't have
reliable reproduction steps