Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghstack: use . instead of max(decendents(.)) for HEAD #310

Closed
wants to merge 2 commits into from
Closed

ghstack: use . instead of max(decendents(.)) for HEAD #310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b58a025
ghstack: use `.` instead of `max(decendents(.))` for HEAD
nemith Dec 8, 2022
83db53a
Merge branch 'main' into pr310
nemith Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eden/scm/ghstack/sapling_shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def _rewrite_args(self, _args: List[str]) -> List[str]:
# not be able to resolve arguments like HEAD, so we must resolve those
# to a full hash before running Git.
if 'HEAD' in args:
top = self._run_sapling_command(['log', '-r', 'max(descendants(.))', '-T', '{node}'])
top = self._run_sapling_command(['log', '-r', '.', '-T', '{node}'])
for index, arg in enumerate(args):
if arg == 'HEAD':
args[index] = top
Expand Down