feat: RawPropsParser add useRawPropsJsiValue parameter
#48231
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
javache
reviewed
Dec 12, 2024
packages/react-native/ReactCommon/react/renderer/core/RawPropsParser.h
Outdated
Show resolved
Hide resolved
…Parser.h Co-authored-by: Pieter De Baets <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this PR we added a change that allows the RawPropsParser to construct its RawValues directly from the
jsi::Valueinstead of converting it tofolly::dynamicfirst.We added a global feature flag to turn this on, however, for migrations it might be better to use this functionality as an opt-in on a component basis. With this change
ComponentDescriptorscan now create their RawPropsParser instance with theuseRawPropsJsiValueflag to opt into it.(Note: a few more changes are needed to make this accessible to the
ComponentDescriptor, for which I opened this follow up PR here)Changelog:
[INTERNAL] [ADDED] - Added
useRawPropsJsiValueparameter toRawPropsParserto opt into skipping folly::dynamic conversions during prop parsing.Test Plan:
Internal change / just make sure all tests are passing.