Add support for Performance.mark events in PerformanceTracer #48200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66704283 |
|
This pull request was exported from Phabricator. Differential Revision: D66704283 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Dec 10, 2024
…k#48200) Summary: Pull Request resolved: facebook#48200 Wires up `Performance.mark()` events, completing support for User Timings in Fusebox. Other changes: - Refactors `reportMeasure` to receive a `duration`. - Fixes conversion for time values (ms -> µs) in emitted trace events. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D66704283
huntie
force-pushed
the
export-D66704283
branch
from
0545a20 to
6fda117
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Dec 11, 2024
…k#48200) Summary: Pull Request resolved: facebook#48200 Wires up `Performance.mark()` events, completing support for User Timings in Fusebox. Other changes: - Refactors `reportMeasure` to receive a `duration`. - Fixes conversion for time values (ms -> µs) in emitted trace events. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D66704283
huntie
force-pushed
the
export-D66704283
branch
from
6fda117 to
ebf6f7a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66704283 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66704283 |
huntie
force-pushed
the
export-D66704283
branch
from
ebf6f7a to
44ec89f
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Dec 11, 2024
…k#48200) Summary: Pull Request resolved: facebook#48200 Wires up `Performance.mark()` events, completing support for User Timings in Fusebox. Other changes: - Refactors `reportMeasure` to receive a `duration`. - Fixes conversion for time values (ms -> µs) in emitted trace events. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D66704283
Summary: Updates `ReactPerfLogger` (now renamed `ReactPerfettoLogger`) to log to Perfetto only. This precedes moving `FuseboxTracer` calls into the existing `PerformanceEntryReporter` for both User Timing events and Interaction events. Changelog: [Internal] Differential Revision: D66600278
…(2/2) (facebook#48043) Summary: Pull Request resolved: facebook#48043 Adds a new `PerformanceTracing` API to replace `ReactPerfLogger` and `FuseboxTracer`. - Mostly a clone of `FuseboxTracer`, with small refactorings. - Exposes a new `CdpTracing.h` header, intended for shared CDP/Chrome types (that will later propagate through to the runtime impl of `performance.mark,measure()`). - These live in a new `jsinspector_tracing` library, to avoid a dependency cycle. **Key change**: With both diffs, `PerformanceTracer` is added to `PerformanceEntryReporter` to initially wire up the `performance.measure` event — replacing the previous routing. - `FuseboxTracer` remains load-bearing for the out-of-tree call to `stopTracingAndWriteToFile()`. Changelog: [Internal] Differential Revision: D66650181 Reviewed By: rubennorte
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Dec 12, 2024
…k#48200) Summary: Pull Request resolved: facebook#48200 Wires up `Performance.mark()` events, completing support for User Timings in Fusebox. Other changes: - Refactors `reportMeasure` to receive a `duration`. - Fixes conversion for time values (ms -> µs) in emitted trace events. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D66704283
huntie
force-pushed
the
export-D66704283
branch
from
44ec89f to
a3d3091
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66704283 |
…k#48200) Summary: Pull Request resolved: facebook#48200 Wires up `Performance.mark()` events, completing support for User Timings in Fusebox. Other changes: - Refactors `reportMeasure` to receive a `duration`. - Fixes conversion for time values (ms -> µs) in emitted trace events. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D66704283
huntie
force-pushed
the
export-D66704283
branch
from
a3d3091 to
be78f73
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66704283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Wires up
Performance.mark()events, completing support for User Timings in Fusebox.Other changes:
reportMeasureto receive aduration.Changelog: [Internal]
Reviewed By: hoxyq
Differential Revision: D66704283