-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pretty-format to v29 #45732
Upgrade pretty-format to v29 #45732
Conversation
Hi @dprevost-LMI! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
dc84824
to
f98243a
Compare
f98243a
to
17a8774
Compare
17a8774
to
063fa76
Compare
@tdn120 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hey sorry for the delays here. In my experience, these updates seem innocuous, but end up causing a cascade of additional changes to keep the repo fully in sync. Most of these are resolved, but I still need to update the Flow spec for pretty-format v29, and then see if anything else still needs to be resolved. |
Summary: As described in [this issue](facebook/react-native#45726), we had a problem where, at runtime, version v29 instead of v26 was used, so upgrading it is the fastest fix. ## Changelog: [GENERAL] [CHANGED] - Upgrade pretty-format to 29.7.0 <!-- For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests X-link: facebook/react-native#45732 Reviewed By: blakef Differential Revision: D60533197 Pulled By: tdn120 fbshipit-source-id: b83dbfe463971abbf00cfebdcc9e5dd6975de0d8
This pull request was successfully merged by @dprevost-LMI in 7bc9244 When will my fix make it into a release? | How to file a pick request? |
Summary:
As described in this issue, we had a problem where, at runtime, version v29 instead of v26 was used, so upgrading it is the fastest fix.
Fixes #45726
Changelog:
[GENERAL] [CHANGED] - Upgrade pretty-format to 29.7.0
Test Plan:
I use console log in the RN tester app