Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pretty-format to v29 #45732

Closed

Conversation

dprevost-LMI
Copy link
Contributor

@dprevost-LMI dprevost-LMI commented Jul 26, 2024

Summary:

As described in this issue, we had a problem where, at runtime, version v29 instead of v26 was used, so upgrading it is the fastest fix.

Fixes #45726

Changelog:

[GENERAL] [CHANGED] - Upgrade pretty-format to 29.7.0

Test Plan:

I use console log in the RN tester app
image

@facebook-github-bot
Copy link
Contributor

Hi @dprevost-LMI!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@react-native-bot
Copy link
Collaborator

Fails
🚫

📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against dc84824

@dprevost-LMI dprevost-LMI force-pushed the update-pretty-format-to-v29 branch from dc84824 to f98243a Compare July 26, 2024 14:18
@dprevost-LMI dprevost-LMI force-pushed the update-pretty-format-to-v29 branch from f98243a to 17a8774 Compare July 26, 2024 16:58
@dprevost-LMI dprevost-LMI force-pushed the update-pretty-format-to-v29 branch from 17a8774 to 063fa76 Compare July 29, 2024 18:51
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2024
@dprevost-LMI dprevost-LMI marked this pull request as ready for review July 31, 2024 14:55
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jul 31, 2024
@facebook-github-bot
Copy link
Contributor

@tdn120 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tdn120
Copy link

tdn120 commented Aug 16, 2024

Hey sorry for the delays here. In my experience, these updates seem innocuous, but end up causing a cascade of additional changes to keep the repo fully in sync. Most of these are resolved, but I still need to update the Flow spec for pretty-format v29, and then see if anything else still needs to be resolved.

facebook-github-bot pushed a commit to facebook/metro that referenced this pull request Aug 28, 2024
Summary:
As described in [this issue](facebook/react-native#45726), we had a problem where, at runtime, version v29 instead of v26 was used, so upgrading it is the fastest fix.

## Changelog:

[GENERAL] [CHANGED] - Upgrade pretty-format to 29.7.0

<!--
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests

X-link: facebook/react-native#45732

Reviewed By: blakef

Differential Revision: D60533197

Pulled By: tdn120

fbshipit-source-id: b83dbfe463971abbf00cfebdcc9e5dd6975de0d8
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 28, 2024
@facebook-github-bot
Copy link
Contributor

@tdn120 merged this pull request in 7bc9244.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @dprevost-LMI in 7bc9244

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade pretty-format to 29
4 participants