fix: use real_path to find plist files in update_ats Cocoapod util #42705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
The update ATS method was removed, rendering this moot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes a pod install failure detailed in #42239 which can occur when the
update_ats_in_plistutility method in a Cocoapod script fails to find an Info.plist in the target folder. It does so by calling the Cocoapodsreal_pathmethod instead of justpathon the file reference, which correctly adds the target folder to the path.Changelog:
[iOS] [Fixed] - Fix pod install error when update_ats unable to find Info.plist in targets
Test Plan:
Updated Ruby unit test:
Also tested using patch-package against my reproduction branch in: chriszs/reproducer-react-native#2
To test, clone the branch,
cd ReproducerApp,yarn,npx pod-install. CI fails with "error Cannot start server in new window because no terminal app was specified" on the build step, but I believe that's unrelated.