Skip to content

Commit

Permalink
Add override to RCTHermesInstance destructor (#48265)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #48265

For some clang warnings configurations, you may hit `-Winconsistent-missing-destructor-override` without this override modifier.

## Changelog

[Internal]

Reviewed By: cipolleschi

Differential Revision: D67203040

fbshipit-source-id: 51f8f9bc4e45ebdb008dc440b779302b1103668a
  • Loading branch information
rozele authored and facebook-github-bot committed Dec 14, 2024
1 parent 9a2b807 commit 00c7174
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class RCTHermesInstance : public JSRuntimeFactory {
std::unique_ptr<JSRuntime> createJSRuntime(
std::shared_ptr<MessageQueueThread> msgQueueThread) noexcept override;

~RCTHermesInstance(){};
~RCTHermesInstance() override{};

private:
CrashManagerProvider _crashManagerProvider;
Expand Down

0 comments on commit 00c7174

Please sign in to comment.