-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update image.md fresco GIF library version #4196
Conversation
with react-native 0.75, this library doesn't work: // For animated GIF support implementation 'com.facebook.fresco:animated-gif:3.1.3' We need to switch to the latest library: // For animated GIF support implementation 'com.facebook.fresco:animated-gif:3.2.0'
Hi @coderBeat! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also update the version of animated-webp
and websupport
to 3.2.0?
Also can we apply the same change to the versioned docs?
@@ -98,7 +98,7 @@ dependencies { | |||
implementation 'com.facebook.fresco:animated-base-support:1.3.0' | |||
|
|||
// For animated GIF support | |||
implementation 'com.facebook.fresco:animated-gif:3.1.3' | |||
implementation 'com.facebook.fresco:animated-gif:3.2.0' | |||
|
|||
// For WebP support, including animated WebP | |||
implementation 'com.facebook.fresco:animated-webp:3.1.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation 'com.facebook.fresco:animated-webp:3.1.3' | |
implementation 'com.facebook.fresco:animated-webp:3.2.0' |
I thought about that, |
They do update in a lockstep so I'd rather keep them aligned rather than recommending mixed version of Fresco |
Duplicate of #4359 |
with react-native 0.75, this library doesn't work:
We need to switch to the latest library: