Skip to content

Commit

Permalink
fix unit tests
Browse files Browse the repository at this point in the history
Summary:
there was a unit test failing, that blocks contbuild for RI https://www.internalfb.com/intern/test/562950028975323?ref_report_id=0

https://www.internalfb.com/sandcastle/workflow/117093590327028273

I debugged the problem to the `os.path.exists(testHostPath)` check which returns `False`, because files provided in the config have never been created in the test run. This diff creates these files to satisfy the check

Differential Revision: D58088315

fbshipit-source-id: bbaf1a555fd008668998c590189ec271e0bce907
  • Loading branch information
Alexander Mukhopad authored and facebook-github-bot committed Jun 3, 2024
1 parent 9b4a7a0 commit b7b807a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions idb/grpc/tests/xctest_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ class XCTestsTestCase(IsolatedAsyncioTestCase):
async def test_extract_paths_from_xctestrun(self) -> None:
with tempfile.TemporaryDirectory() as tmp_dir:
file_path = os.path.join(tmp_dir, "test.plist")
with open(os.path.join(tmp_dir, "rest1"), "w") as rest1:
rest1.write("rest1")
with open(os.path.join(tmp_dir, "rest2"), "w") as rest2:
rest2.write("rest2")
with open(file_path, "wb+") as f:
plistlib.dump(
{
Expand Down

0 comments on commit b7b807a

Please sign in to comment.