[WIP] Array-based List type #2154
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ncave
commented
Sep 9, 2020
•
ncave
commented
- Faster than F# linked list, when micro-benchmarked.
- Overall, still slower in larger tests (FCS-JS) than using JS linked list.
|
Rebased from #2156. |
|
This is still marked as WIP, so you want to merge it? |
|
@alfonsogarciacaro It's ready, but it does result in about 10% perf impact, so further optimizations are needed. We can keep it on the back-burner for now. |
ncave
force-pushed
the
next2
branch
10 times, most recently
from
54b3257
to
8b6c529
Compare
ncave
force-pushed
the
next2
branch
3 times, most recently
from
e134310
to
bf476bc
Compare
ncave
force-pushed
the
next2
branch
2 times, most recently
from
bcea005
to
0e809d3
Compare
ncave
force-pushed
the
next2
branch
3 times, most recently
from
c9a6aa2
to
849fe9a
Compare
ncave
force-pushed
the
next2
branch
3 times, most recently
from
4a2924a
to
300c888
Compare
|
Do you think it would help if we allocated a few slots in advance and increase it as we add more elements? (I think System.Generic.Collections.List does this, although maybe the JS engine does the same internally) |
ncave
force-pushed
the
next2
branch
2 times, most recently
from
3316418
to
9f6ae2a
Compare
alfonsogarciacaro
force-pushed
the
nagareyama
branch
from
2358f11
to
74a47b7
Compare
ncave
force-pushed
the
next2
branch
4 times, most recently
from
73f5e45
to
cad4cea
Compare
ncave
force-pushed
the
next2
branch
2 times, most recently
from
69802d1
to
9e80a55
Compare
This was referenced Jan 16, 2021
alfonsogarciacaro
force-pushed
the
main
branch
from
bd63a98
to
1895f4d
Compare
alfonsogarciacaro
force-pushed
the
main
branch
from
1527047
to
a69e20d
Compare
alfonsogarciacaro
force-pushed
the
main
branch
from
87e6a8c
to
b627427
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.