Fix #2295: Ignore some errors

fable-compiler · Nov 28, 2020 · edb200b · edb200b
1 parent 0fc1f29
commit edb200b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/src/Fable.Transforms/FSharp2Fable.Util.fs b/src/Fable.Transforms/FSharp2Fable.Util.fs
@@ -1148,6 +1148,12 @@ module Util =
             | Atts.global_ | Naming.StartsWith Atts.import _ -> true
             | _ -> false)
 
+    let isEmittedOrImportedMember (memb: FSharpMemberOrFunctionOrValue) =
+        memb.Attributes |> Seq.exists (fun att ->
+            match att.AttributeType.TryFullName with
+            | Some(Naming.StartsWith Atts.emit _ | Atts.global_ | Naming.StartsWith Atts.import _) -> true
+            | _ -> false)
+
     let isFromDllRef (ent: Fable.Entity) =
         match ent.Ref.Path with
         | Fable.AssemblyPath _ | Fable.CoreAssemblyName _ -> true

diff --git a/src/Fable.Transforms/FSharp2Fable.fs b/src/Fable.Transforms/FSharp2Fable.fs
@@ -1049,9 +1049,11 @@ let private transformMemberDecl (com: FableCompiler) (ctx: Context) (memb: FShar
                 let declaringEntity = FsEnt declaringEntity :> Fable.Entity
                 if isGlobalOrImportedEntity declaringEntity then ()
                 elif isErasedOrStringEnumEntity declaringEntity then
-                    let r = makeRange memb.DeclarationLocation |> Some
-                    "Erased types cannot implement abstract members"
-                    |> addError com ctx.InlinePath r
+                    // Ignore abstract members for classes, see #2295
+                    if declaringEntity.IsFSharpUnion || declaringEntity.IsFSharpRecord then
+                        let r = makeRange memb.DeclarationLocation |> Some
+                        "Erased unions/records cannot implement abstract members"
+                        |> addError com ctx.InlinePath r
                 else
                     // Not sure when it's possible that a member implements multiple abstract signatures
                     memb.ImplementedAbstractSignatures
@@ -1096,7 +1098,8 @@ let rec private getUsedRootNames (com: Compiler) (usedNames: Set<string>) decls
             | sub ->
                 getUsedRootNames com usedNames sub
         | MemberOrFunctionOrValue(memb,_,_) ->
-            if memb.IsOverrideOrExplicitInterfaceImplementation then usedNames
+            if memb.IsOverrideOrExplicitInterfaceImplementation
+                || isInline memb || isEmittedOrImportedMember memb then usedNames
             else
                 let memberName, _ = getMemberDeclarationName com memb
                 addUsedRootName com memberName usedNames