Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-action dialogs #217

Merged
merged 4 commits into from
Mar 11, 2023
Merged

Fix multi-action dialogs #217

merged 4 commits into from
Mar 11, 2023

Conversation

the-jesus
Copy link

This fixed the problem with the confirmation dialog of the multi-action dialog. Also fixing that presets couldn't be deleted.

@t0b3
Copy link
Collaborator

t0b3 commented Nov 20, 2022

double check you committed everything and tested it thouroughly...

Traceback (most recent call last):
  File "~/.config/inkscape/extensions/silhouette_multi.py", line 33, in <module>
    from silhouette.Dialog import Dialog
ModuleNotFoundError: No module named 'silhouette.Dialog'

@the-jesus
Copy link
Author

Yeah, don't know why, but I must have forgotten to check in the file. I have never programmed python before, tbh. So I hope it works now.

@t0b3
Copy link
Collaborator

t0b3 commented Nov 21, 2022

running with this PR leads to

Traceback (most recent call last):
  File "/home/thomas/.config/inkscape/extensions/silhouette_multi.py", line 33, in <module>
    from silhouette.Dialog import Dialog
  File "/home/thomas/.config/inkscape/extensions/silhouette/Dialog.py", line 1, in <module>
    import wx
ModuleNotFoundError: No module named 'wx'

seems like there is no clean error handling implemented for cases w/o wx. can you reorder the imports and softfail with some more meaningful msg?

... and obviously you need to tweak your code to pass the tests

PS: can you elaborate on what exact problem this PR fixes? feel free to report an issue on that... THX

@the-jesus
Copy link
Author

Please excuse me for making so much work. I now try to deal with the errors regarding the missing wx library.
The changes should fix the issue with the dialogs of the multi action. The "preset delete" and the "execute" doesn't work. This problem is mentioned here: #213
So please give it another try.

@t0b3
Copy link
Collaborator

t0b3 commented Nov 22, 2022

@the-jesus thank you for your work and your explanations
@gwhitney can you review this PR?

@gwhitney
Copy link
Contributor

Haven't used inkscape-silhouette in a while (haven't happened to need to cut anything intricate) but would be happy to give this a spin. However, I am busy through Thanksgiving weekend -- can it wait until the following week?

@the-jesus
Copy link
Author

Hi, how have you been?
Here is just a quick reminder. 😝

@t0b3 t0b3 merged commit 7179553 into fablabnbg:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants