Undo Patch abstraction #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am trying to implement incremental updates and the patch abstraction is the wrong way to go about doing it, because you in general don't have a base tree to apply the patch on; you need the full git tree object somehow. This will break ghexport when we take these updates but it's going to be complicated to handle anyway, deal with it when we get there. Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Dec 4, 2023
I am trying to implement incremental updates and the patch abstraction is the wrong way to go about doing it, because you in general don't have a base tree to apply the patch on; you need the full git tree object somehow. This will break ghexport when we take these updates but it's going to be complicated to handle anyway, deal with it when we get there. Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 3e8841044f95af9f83452ec0daf482dc8dbc12f5 Pull Request resolved: #198
This was referenced Dec 5, 2023
ezyang
added a commit
that referenced
this pull request
Dec 5, 2023
I am trying to implement incremental updates and the patch abstraction is the wrong way to go about doing it, because you in general don't have a base tree to apply the patch on; you need the full git tree object somehow. This will break ghexport when we take these updates but it's going to be complicated to handle anyway, deal with it when we get there. Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 3e8841044f95af9f83452ec0daf482dc8dbc12f5 Pull Request resolved: #198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I am trying to implement incremental updates and the patch abstraction
is the wrong way to go about doing it, because you in general don't have
a base tree to apply the patch on; you need the full git tree object
somehow. This will break ghexport when we take these updates but it's
going to be complicated to handle anyway, deal with it when we get
there.
Signed-off-by: Edward Z. Yang [email protected]