fixes

externl · Dec 4, 2024 · 010c66d · 010c66d
1 parent 2d4a1bc
commit 010c66d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -64,9 +64,10 @@ jobs:
         with:
           use_ccache: false
 
-      - name: Build C#
-        working-directory: ./csharp
-        run: make
+      - name: Build
+        run: |
+          make -C cpp srcs
+          make -C csharp
 
       - name: Generate C# Coverage
         working-directory: ./csharp

diff --git a/csharp/msbuild/coverage.runsettings b/csharp/msbuild/coverage.runsettings
@@ -3,6 +3,7 @@
     <DataCollectionRunSettings>
         <DataCollectors>
             <DataCollector friendlyName="Code Coverage">
+                <Format>Cobertura</Format>
                 <Configuration>
                     <CodeCoverage>
                         <ModulePaths>

diff --git a/scripts/Util.py b/scripts/Util.py
@@ -3950,9 +3950,7 @@ def getCommandLine(self, current, process, exe, args):
         if current.config.dotnetCoverageSession != "":
             # escapign \" is requried for passing though from dotnet-coverage -> dotnet -> exe
             cmd = cmd.replace('\\"', '\\\\\\"')
-            cmd = (
-                f"dotnet-coverage connect {current.config.dotnetCoverageSession} {cmd}"
-            )
+            cmd = f"dotnet-coverage connect --nologo {current.config.dotnetCoverageSession} {cmd}"
 
         return cmd