Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initial scripts #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

IamLizu
Copy link
Member

@IamLizu IamLizu commented Oct 1, 2024

  • Script for creating label in all existing repo of an organization
  • Script for subscribing to all repo of an organization for triage members
  • Improved readme


// Replace with your GitHub token and organization name
const GITHUB_TOKEN = 'token';
const ORGANIZATION_NAME = 'pillarjs';
Copy link
Member

@bjohansebas bjohansebas Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be passed as command-line arguments using process.argv

const ORGANIZATIONS = process.argv.slice(2)

for (const arg of ORGANIZATIONS) {
...
}

Or simply add the three organizations.

@IamLizu
Copy link
Member Author

IamLizu commented Oct 2, 2024

Hey @bjohansebas 👋

Yes, organization can be passed as arguments. Additionally, we can do the following things,

  1. Take token as argument (making sure its not logged as it would expose it to programs like ps.)
  2. Take organization(s) as argument
  3. Take label, color as argument
  4. etc.

However, I don't that effort is required here. I think we should put more focus on the task at hand instead of making these scripts all customizable as they are intended for a few people only?

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't there a package.json? I don't think it matters to install all the packages even if we're just using a single script.

@IamLizu
Copy link
Member Author

IamLizu commented Oct 4, 2024

Hey @bjohansebas 👋

Yeah, I thought about adding a package.json too. I was a bit hesitant to be honest. I was thinking whether I should add it or not.

Then the negative arguments won in mind, such as,

  1. Right now we have two scripts that uses different packages, not everyone may use both scripts
  2. We do not need any scripts to run via the package.json

But yes, its merely my opinion. Let's wait and hear opinion from other people as well. There's certainly no harm in adding the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants