-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace /{{ page.lang }}/changelog/4x.html with /en/changelog/ #1685
base: gh-pages
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
These changes look good to me. Thanks for your contribution! |
My pleasure! If there's anything else regarding this issue, please let me know. I'm happy to try and help |
We should update the home in (th) |
Hi @carlosstenzel! Just wanted to confirm if the line below is what you were referring to:
If this is the correct line, I was wondering if I could have your advice on what I should change it to - I'm a little bit new to the project and want to follow the best practices/follow any existing examples! Edit: I can also the header-id.html file too |
Hi @peterdanwan |
Hey Carlo, what do you mean by this? Which part? |
That should be in another PR, and I don't think we should invest effort into that for now, Many home pages are a bit outdated |
c099619
to
a3e5024
Compare
Hi @chrisdel101, @carlosstenzel, @bjohansebas! I rebased my changes onto what's been added to |
This PR:
_includes/header/header-th.html
:<a href="/{{ page.lang }}/changelog/4x.html">บันทึกการเปลี่ยนแปลง</a>
<a href="/en/changelog/">บันทึกการเปลี่ยนแปลง</a>
_includes/header/header-id.html
:<a href="/{{ page.lang }}/changelog/4x.html">Release Change Log</a>
<a href="/en/changelog/">Release Change Log</a>
css/uz.css
file, following the same styles ascss/tr.css
Demonstration of
http://localhost:4000/id/
Release Change Log link working:2024-11-17.15-00-17.mp4
Demonstration of
http://localhost:4000/th/
Release Change Log link working:2024-11-17.15-01-32.mp4