Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yarn-workspaces] Upgrade to the bin #330

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

byCedric
Copy link
Member

This is just to spark the discussion of removing it, here is why:

  1. We have better monorepo support now, you shouldn't need expo-yarn-workspaces for a monorepo with apps.
  2. expo-yarn-workspaces was (and I think still is) considered to be an internal tool at Expo. But, because this was almost the only way to actually set up a monorepo, it kinda leaked out into the public.

We also do have better monorepo examples to pick from:

@brentvatne
Copy link
Member

i think we should keep an example to make it easy to init a minimal monorepo in this repo. we can refer to eas-mono-repo-example in the readme but imo it includes too much code for people to clone and get started, you need to delete a bunch of code before you get started

@byCedric
Copy link
Member Author

How about creating a "plain and stupid" example of a monorepo, without using expo-yarn-workspaces in this repo?

@byCedric byCedric marked this pull request as draft November 5, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants