Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to select environments manually in env:push #2637

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khamilowicz
Copy link
Contributor

Why

ENG-13853: Prompt user to enter the environment when not provided vs fail and rerun when using eas env:push

If the environment is not provided, we ask the user about it in other commands, I think we can do the same here for consistency vs throwing an error and having the user rerun it

Test Plan

Tested manually

Copy link

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

@khamilowicz khamilowicz added the no changelog PR that doesn't require a changelog entry label Oct 18, 2024
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

Size Change: -1.04 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -1.04 kB (0%)

compressed-size-action

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.11%. Comparing base (c07fd22) to head (047c7c7).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/push.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
+ Coverage   53.10%   53.11%   +0.01%     
==========================================
  Files         564      564              
  Lines       21498    21496       -2     
  Branches     4212     4212              
==========================================
+ Hits        11415    11416       +1     
+ Misses      10053    10050       -3     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants