Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update introduction.md #763

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update introduction.md #763

wants to merge 1 commit into from

Conversation

csprasad
Copy link

@csprasad csprasad commented Aug 6, 2024

Removed Unused Declaration of Variable speed.

I noticed that the variable speed is declared but never used in the code example. To avoid confusion, I suggest removing this unused declaration.

I noticed that the variable speed is declared but never used in the code example. To avoid confusion, especially for beginners, I suggest removing this unused declaration.
@BNAndras
Copy link
Member

BNAndras commented Sep 9, 2024

Seems like speed is used later in myChar.stats = CharacterStats(health: 72.8, speed: 19, strength: 6). So you'll need to edit that bit later on as well.

@meatball133
Copy link
Member

I don't really see how this adds confusion, since even though if not used it can still be important for the codebase itself, thereby I wouldnt strictly speaking say that it should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants