-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation script #98
Conversation
Related: #97 |
I'm looking into it! Btw: Not sure if I'm totally missing the point, but for the Github workflows, we could simply add the Arturo action like:
and the binary should be available in all subsequent steps. Do you think it would make sense for me to edit the Test workflow? If so, I'll do it right now! 😉 |
Just uncommented the "curl install" line (it has supposedly been fixed as of today) and commented out the call to |
Yeah that would be nice. |
If CI passes, then the old code can be removed. |
The link was still pointing to the previous script
OK. So, let's see... I think I've fixed the installation script... and it should be working as it should. If the CI succeeds (just to make sure the installation script works), I would then change the Test workflow so that it uses our existing action (for CI purposes, I think this is even more efficient). And if it succeeds again, we'll be good to go, by any possible definition 😉 |
Agreed! |
You've fixed CI, only it turns out that one of our example solutions doesn't work with the latest version :) @BNAndras any idea? |
The culprit is apparently this: And related to how we handle the product of empty blocks: which we have fixed to be in line with most common approaches to the issue: |
(instead of custom script)
I replaced the Arturo action as we said and tried to fix the error above. Let's see... |
Perfect! Thanks |
Awesome! 😉 |
Minor changes to align the installation script with current naming conventions in our Nightly releases.
See also: https://discord.com/channels/765519132186640445/1285475027801739307/1293811512737140839
Obviously, another workaround could be directly using the installation script: