Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation script #98

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Conversation

drkameleon
Copy link
Contributor

@drkameleon drkameleon commented Oct 10, 2024

Minor changes to align the installation script with current naming conventions in our Nightly releases.

See also: https://discord.com/channels/765519132186640445/1285475027801739307/1293811512737140839


Obviously, another workaround could be directly using the installation script:

curl -sSL https://get.arturo-lang.io | sh -s -- --nightly

@drkameleon
Copy link
Contributor Author

Related: #97

@ErikSchierboom
Copy link
Member

@drkameleon CI now fails: https://github.com/exercism/arturo/actions/runs/11268216954/job/31336270193?pr=98

@drkameleon
Copy link
Contributor Author

@drkameleon CI now fails: https://github.com/exercism/arturo/actions/runs/11268216954/job/31336270193?pr=98

I'm looking into it!

Btw:

Not sure if I'm totally missing the point, but for the Github workflows, we could simply add the Arturo action like:

- name: Install Arturo
  uses: arturo-lang/arturo-action@main
  with: 
      token: ${{ secrets.GITHUB_TOKEN }}

and the binary should be available in all subsequent steps.

Do you think it would make sense for me to edit the Test workflow? If so, I'll do it right now! 😉

@drkameleon
Copy link
Contributor Author

Just uncommented the "curl install" line (it has supposedly been fixed as of today) and commented out the call to download_nightly, since we won't need it. (and most likely it is to be removed altogether)

@ErikSchierboom
Copy link
Member

Do you think it would make sense for me to edit the Test workflow? If so, I'll do it right now! 😉

Yeah that would be nice.

@ErikSchierboom
Copy link
Member

(and most likely it is to be removed altogether)

If CI passes, then the old code can be removed.

The link was still pointing to the previous script
@drkameleon
Copy link
Contributor Author

OK. So, let's see... I think I've fixed the installation script... and it should be working as it should.

If the CI succeeds (just to make sure the installation script works), I would then change the Test workflow so that it uses our existing action (for CI purposes, I think this is even more efficient).

And if it succeeds again, we'll be good to go, by any possible definition 😉

@ErikSchierboom
Copy link
Member

Agreed!

@ErikSchierboom
Copy link
Member

You've fixed CI, only it turns out that one of our example solutions doesn't work with the latest version :) @BNAndras any idea?

@drkameleon
Copy link
Contributor Author

drkameleon commented Oct 10, 2024

The culprit is apparently this:
https://github.com/exercism/arturo/blob/main/exercises/practice/largest-series-product/.meta/src/example.art#L12

And related to how we handle the product of empty blocks:
arturo-lang/arturo#1693

which we have fixed to be in line with most common approaches to the issue:

Screenshot 2024-10-10 at 12 17 40

@drkameleon
Copy link
Contributor Author

I replaced the Arturo action as we said and tried to fix the error above. Let's see...
Unless I've totally messed up sth trivial, we should be good to go!

@ErikSchierboom ErikSchierboom merged commit 371be20 into exercism:main Oct 10, 2024
2 checks passed
@ErikSchierboom
Copy link
Member

Perfect! Thanks

@drkameleon
Copy link
Contributor Author

drkameleon commented Oct 10, 2024

Perfect! Thanks

Awesome! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants