Skip to content

Commit

Permalink
Set papermill autosave-every to 60
Browse files Browse the repository at this point in the history
In the previous commit a049a09 ,
setting this to 0 was intended as a mitigation for possible concurrent
writes, but there is now evidence that running out of memory leads to
PermissionDenied when saving notebooks (it's reproducible in one case)

The autosave-every setting should lead to better debuggability and
getting info about the notebook state quicker during execution.
  • Loading branch information
totycro committed Aug 8, 2024
1 parent 0ebbf77 commit 6da56ef
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 1.5.0
* Set autosave-every to 60

## 1.4.0
* Implement pagination

Expand Down
2 changes: 1 addition & 1 deletion pygeoapi_kubernetes_papermill/notebook.py
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ def create_job_pod_spec(
f'"{output_notebook}" '
"--engine kubernetes_job_progress "
"--request-save-on-cell-execute "
"--autosave-cell-every 0 "
"--autosave-cell-every 60 "
f'--cwd "{working_dir(requested.notebook)}" '
+ ("--log-output " if self.log_output else "")
+ (f"-k {requested.kernel} " if requested.kernel else "")
Expand Down

0 comments on commit 6da56ef

Please sign in to comment.