-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add erpc chart #345
feat: add erpc chart #345
Conversation
hey @paolofacchinetti . Thanks for the draft PR!
You could set some default Pod securityContext, which will prevent any containers from that pod to run as root. Example, in securityContext:
fsGroup: 10001
runAsGroup: 10001
runAsNonRoot: true
runAsUser: 10001
Yeah, that makes sense 👍 |
You could have an init container, that mounts the configmap and env vars and then performs an |
Hey @skylenet, thanks for the feedback!
Done in 2dbec96 I was blocked due to a misbelief that erpc could only look for the config file under the
Done in f5a8051 Apparently erpc already performs env substitution natively. |
Awesome! Can you update the content in |
Oh you're right, my bad. Now it should be okay 😄 |
Adds the erpc chart and closes #337
A few things i'd love to get some feedback on
I based my implementation and the relative config defaults on the railway-deployment for erpc. I'm not a fan of having the config (which contains remote RPC apikeys) be stored in a configmap, but from how they use gotemplate to load env variables into the config file i assume erpc doesnt support config overrides from environment variables.
The prepackaged docker image by erpc is hardcoded to run as root. It's fairly easy to change that with a new Dockerfile but we would have to rehost the image on another registry and keep it updated. Not sure on what the policies are for that stuff, but i'm open to discuss
I didnt include postgres or prometheus/grafana since they arent a requirement (nor the default config) and people can just deploy those with the relative charts/operators.