add dynamic spec check conditions #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces dynamic spec check conditions that are evaluated using govaluate.
These conditions exclude spec values that are introduced by disabled forks.
This fixes problems with dora running on holesky or sepolia.
More and more clients release electra code, which is not yet used, but spec values already exposed.
Upgrading our testnet nodes leads to spec mismatches for electra/peerdas values as some clients already include them and some not.
This is however not a real issue, as electra is not even planned for activation on these testnets.
With this PR, spec values of future forks (electra, peerdas) are only checked if the corresponding fork is planned for activation.