Remove unnecessary Hardhat-related CI jobs #754
Conversation
|
The second commit fixes an unrelated thing in the CI: it assumes that the Hardhat repo only has releases related to Hardhat, but we also publish our plugins releases there. This means that if the latest release is a plugin, the job fails. I fixed that by getting all releases, and getting the first one whose tag starts with The node-v10 job is still failing, but that also seems unrelated to my changes here. |
There was a problem hiding this comment.
Thank you very much @fvictorio! It looks good to me, except for one small comment :)
| https://api.github.com/repos/nomiclabs/hardhat/releases/latest \ | ||
| | jq --raw-output .tag_name \ | ||
| https://api.github.com/repos/nomiclabs/hardhat/releases \ | ||
| | jq --raw-output 'map(select(.tag_name | test("^hardhat@"))) | .[0].tag_name' \ |
There was a problem hiding this comment.
Is the latest release always the first element in the list?
There was a problem hiding this comment.
It is according to my single, manual test 😅 Sadly, the docs don't specify this.
But I think even in the (IMO unlikely) case that you get an older release, this is still better than failing every time the latest release is a Hardhat plugin, something that happens often enough.
Yeah, it is unrelated. I will fix it in a follow up PR, thanks. |
As discussed in #752, this removes two Hardhat-related jobs that are not necessary and that will stop working soon when we remove those tests from the Hardhat repo.