Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workarounds for running tests against wasm rebuilds of old compilers. #441

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ekpyron
Copy link
Member

@ekpyron ekpyron commented Jan 13, 2020

@axic I used this branch for running the solc-js tests against the wasm rebuilds now... additionally I patched compiler.js on the fly to replace 'latest' with the respective version string...

Making this a draft, since we'll probably need to discuss if and how this should end up in master.

@ekpyron ekpyron requested a review from axic January 13, 2020 13:38
@axic
Copy link
Member

axic commented Jan 13, 2020

@ekpyron ah we're not testing the CLI with different versions though.

@ekpyron
Copy link
Member Author

ekpyron commented Jan 13, 2020

Not in the "normal" solc-js test suite... what I do in https://github.com/ethereum/solidity/blob/98ec970813c47ebbb3ad9b11042116de5b89aac5/scripts/wasm-rebuild/docker-scripts/rebuild_tags.sh#L158 (part of ethereum/solidity#8118) is to copy the "new old" soljson.js over to test it - that's how I noticed that they don't run without these changes.

But yeah: we need to decide what to do about this - if we make the CLI tests compatible with old versions, then we should probably always run them against old versions as well...

Related to this: I'd also vote for making it possible to run the test suite against one particular soljson.js version, resp. even better against a particular file only without needing to edit the test suite for it.

@ekpyron
Copy link
Member Author

ekpyron commented Jan 13, 2020

Not sure how difficult it would be to let the npm/tape stuff take a soljson.js file as optional argument or something like that... my experience with them is only tangential...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants