Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmented lint configuration #257

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ff2005
Copy link

@ff2005 ff2005 commented Oct 10, 2021

No description provided.

@gfwilliams
Copy link
Member

Thanks! So what does this actually change in terms of what Lint now picks up or doesn't pick up?

@ff2005
Copy link
Author

ff2005 commented Oct 11, 2021

Thanks! So what does this actually change in terms of what Lint now picks up or doesn't pick up?

My main thing was to have the "undef" and "unused" set to "true", unfortunately I don't know what Emscripten engine is all about in tern of similarity with node, but, I put node: true and browser: false so it is ok with things like "setTimeout()" but not things like "window." (please, change any "defaultLintFlags" if you find this not ok).

@ff2005
Copy link
Author

ff2005 commented Oct 11, 2021

Please, do test it.
I say this, because, there is probably things that needs to go into the "defaultLintFlags. globals" that I didn't pick (like the "g: false" that I added) so it doesn't get reported has undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants