Make our nightly CI checks pass #2356
Draft
+266
−267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
approved these changes
Oct 16, 2024
We can merge in any order, I don't mind having to do some rebasing. This wasn't a ton of work, don't want to make your life too difficult. Just lemme know. |
|
Will hold off on merging this to avoid making other contributor's lives difficult for the time being. Will update when it's convenient to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been failing for awhile now, thanks to #2351 this became much easier to resolve.
Largely the failures were just due to lifetime elision, some small doc-comment related lint errors as well.
I have allowed the
static_mut_refspackage-wide for some packages; we are aware of the use of statics, I don't intend to rewrite these for this PR. Can be addressed at some other time.No changes here warrant a
CHANGELOG.mdentry IMO.Successful run: https://github.com/jessebraham/esp-hal/actions/runs/11365052005