Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backmerge: #5659 - Moving of selected microstructures on macro canvas works wrong #5820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Backmerge: #5659 - Moving of selected microstructures on macro canvas works wrong #5820

wants to merge 1 commit into from

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Oct 18, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

  • removed hidden chems created for molecules in model from selection
  • fixed performance by collecting moving

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@rrodionov91
#5659 - Moving of selected microstructures on macro canvas works wrong (
a4eee96 
#5769)

- removed hidden chems created for molecules in model from selection
- fixed performance by collecting moving
@rrodionov91 rrodionov91 linked an issue Oct 18, 2024 that may be closed by this pull request
Moving of selected microstructures on macro canvas works wrong #5659
Open
@rrodionov91 rrodionov91 changed the title #5659 - Moving of selected microstructures on macro canvas works wrong Backmerge: #5659 - Moving of selected microstructures on macro canvas works wrong Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zhirnoff Zhirnoff Zhirnoff approved these changes

@NataliaLoginova NataliaLoginova Awaiting requested review from NataliaLoginova

@svvald svvald Awaiting requested review from svvald

Assignees

@rrodionov91 rrodionov91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving of selected microstructures on macro canvas works wrong
2 participants
@rrodionov91 @Zhirnoff