Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5372 – Toggling between Flex and Sequence modes causes loosing layout info #5616

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mnmsvlw
Copy link
Collaborator

@mnmsvlw mnmsvlw commented Oct 1, 2024

How the feature works? / How did you fix the issue?

This PR fixes the issue with data loss in the layout when switching from flex to sequence mode. The problem was that the initialize method of the SequenceMode class called the reArrangeChains function with the isSnakeMode = true parameter, which triggered chain rearrangement

Update: isSnakeMode is disabled only when switching modes. The layout will be still recalculated after sequence updates. To manage this, a new argument needReArrangeChains has been added to the initialize method of the SequenceMode

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggling between Flex and Sequence modes causes loosing layout info
1 participant