-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete files #985
base: main
Are you sure you want to change the base?
fix: delete files #985
Conversation
34662a5
to
eebd1a7
Compare
@@ -7,6 +7,7 @@ | |||
import minio | |||
import sqlalchemy.orm | |||
import sqlalchemy_filters.exceptions | |||
from badgerdoc_storage.storage import get_storage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import the storage instead of a dedicated function, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
assets/assets/utils/minio_utils.py
Outdated
except NotImplementedError as e: | ||
logger_.error(f"{storage.__class__}.remove: {e}") | ||
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
assets/assets/utils/minio_utils.py
Outdated
@@ -236,15 +236,19 @@ def upload_thumbnail( | |||
return True | |||
|
|||
|
|||
def delete_one_from_minio(bucket: str, obj: str, client: minio.Minio) -> bool: | |||
def delete_one_from_minio( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you rename it to something more generic, considering the fact we are not linked to minio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
a6978b6
to
c97e9a4
Compare
d5c6030
to
ccaaed9
Compare
No description provided.