-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Python3.12 tenants support #822
Open
khyurri
wants to merge
1
commit into
main
Choose a base branch
from
feature/python3.12
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khyurri
force-pushed
the
feature/python3.12
branch
from
January 6, 2024 11:36
12bb554
to
66bf8e6
Compare
khyurri
changed the title
Add tenant dependency Python 3.12 support
feat: add Python3.12 tenants support
Jan 6, 2024
khyurri
force-pushed
the
feature/python3.12
branch
3 times, most recently
from
January 6, 2024 11:47
563044d
to
66ad790
Compare
cakeinsauce
reviewed
Jan 6, 2024
cakeinsauce
reviewed
Jan 6, 2024
cakeinsauce
reviewed
Jan 6, 2024
cakeinsauce
reviewed
Jan 6, 2024
cakeinsauce
reviewed
Jan 6, 2024
cakeinsauce
reviewed
Jan 6, 2024
cakeinsauce
reviewed
Jan 6, 2024
cakeinsauce
reviewed
Jan 6, 2024
khyurri
force-pushed
the
feature/python3.12
branch
from
January 8, 2024 16:19
55e6f7b
to
3a728a6
Compare
cakeinsauce
reviewed
Jan 8, 2024
self, | ||
key: str = "", | ||
algorithm: str = "RS256", | ||
# TODO: Fix type from bagerdoc to badgerdoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we can remove this todo
cakeinsauce
reviewed
Jan 8, 2024
``` | ||
This dependency will: | ||
1) Check if incoming request came with header `Authorization`, if that header wasn't provided Error 401 will be raised. | ||
2) If header `Authorization` exists, dependency will try to validate it with signature key or url those you put as args to dependency `tenant = get_tenant_info(key="SECRET") / tenant = get_tenant_info(url="http://bagerdoc-keycloack")`. If is key invalid or token is expired 401 Error will be raised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i missed this one
Suggested change
2) If header `Authorization` exists, dependency will try to validate it with signature key or url those you put as args to dependency `tenant = get_tenant_info(key="SECRET") / tenant = get_tenant_info(url="http://bagerdoc-keycloack")`. If is key invalid or token is expired 401 Error will be raised. | |
2) If header `Authorization` exists, dependency will try to validate it with signature key or url those you put as args to dependency `tenant = get_tenant_info(key="SECRET") / tenant = get_tenant_info(url="http://badgerdoc-keycloak")`. If is key invalid or token is expired 401 Error will be raised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.