-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/one helm deploy #154
base: main
Are you sure you want to change the base?
Feat/one helm deploy #154
Conversation
…m#28) * Add category hierarchy response (epam#5) Co-authored-by: Magic Tears Asunder <[email protected]> Co-authored-by: Svetlana Bilevich <[email protected]> Co-authored-by: theoriginmm <[email protected]> Co-authored-by: Denis Rybakov <[email protected]> Co-authored-by: minev-dev <[email protected]> Co-authored-by: Svetlana Bilevich <[email protected]> Co-authored-by: Kirill Sosnovskiy <[email protected]> Co-authored-by: Shulaev Andrei <[email protected]> Co-authored-by: Andrey Shulaev <[email protected]>
Co-authored-by: thinklab <[email protected]>
Co-authored-by: Fedor Spiridonov <[email protected]>
CI fix postgres and enable all tests
Co-authored-by: Roman Kuzianov <[email protected]>
…_services fix: fix failing tests for 'annotation'
…by-dataset#59 fix: bug with datasets filters
limits: | ||
memory: "1000Mi" | ||
cpu: "400m" | ||
{{ .Values.resources | default .Values.global.resources | toYaml | indent 10 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused, what's going on here?
If I define resources in global value file, I will get the same resource value for each app. I would prefere to have the ability to manage resources for each app.
If I don't define resources in global values, I will get resources: null.
Example:
global values.yaml
# resources: {}
# requests:
# memory: "1000Mi"
# cpu: "000m"
# limits:
# memory: "0000Mi"
# cpu: "000m"
values.yaml
resources:
requests:
memory: "200Mi"
cpu: "200m"
limits:
memory: "1000Mi"
cpu: "400m"
Output:
- image: "818863528939.dkr.ecr.eu-central-1.amazonaws.com/badgerdoc/users:0.1.2-0d3e100"
imagePullPolicy: "Always"
name: users
resources:
null
```
- name: S3_ENDPOINT_URL | ||
value: "http://minio" | ||
value: "{{ default .Values.global.s3Endpoint .Values.s3Endpoint }}" | ||
{{- if .Values.secret.s3user }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean S3 user?
key: S3_PASS | ||
key: S3_PASS | ||
{{- end }} | ||
{{- if .Values.extraEnvs }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The annotation service has S3_PREFIX property.
Did you miss that or do we need to configure via extraEnvs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also. I think extraEnvs should be accessable from global values.
{{- if .Values.secret.s3password }} | ||
S3_PASS: {{ .Values.secret.s3password | b64enc }} | ||
{{- end }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls add newline at the end of the file.
Example of helm charts to deploy all micro-services at once