Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: supports edm 4 on Linux #15

Merged
merged 9 commits into from
Oct 8, 2024
Merged

ENH: supports edm 4 on Linux #15

merged 9 commits into from
Oct 8, 2024

Conversation

dpinte
Copy link
Member

@dpinte dpinte commented Oct 8, 2024

Closes #14

@dpinte dpinte requested a review from mdickinson October 8, 2024 12:07
@mdickinson
Copy link
Member

@dpinte I'm only seeing changes in the src/ directory in this PR. I think those changes need to be compiled so that dist/ is updated, too.

@rahulporuri
Copy link
Contributor

https://github.com/enthought/setup-edm-action/blob/f603052ca1dd0704b80cd415143c116296fe9181/DEVELOPING.md has information on how dist/ can be updated

@dpinte
Copy link
Member Author

dpinte commented Oct 8, 2024

ha ha, thanks guys! Looking into it.

mdickinson
mdickinson approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpinte dpinte merged commit e0ea43d into main Oct 8, 2024
3 checks passed
@dpinte dpinte deleted the enh/add-edm-4-support branch October 8, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for edm 4.x
3 participants
@dpinte @mdickinson @rahulporuri