MAINT: Update Node to 20 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes LGTM. @shoeb-github @andrewcollette Once this is merged we'll need a new release of the action. Is that something that the platform team can handle? |
mdickinson
approved these changes
Jan 29, 2024
|
@rahulporuri For future updates, is the procedure that you went through to update this action documented somewhere - e.g., on the wiki? |
https://github.com/enthought/setup-edm-action/blob/b7fe1a92741934ed4504a22e61ffdad71a91eca9/DEVELOPING.md - thank you Kit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12
This PR follows the instructions in the "DEVELOPING.md" document to update Node to version 20. In addition, a few unrelated changes have been made
Note that this PR makes a forward looking change to the documentation -
enthought/setup-edm-action@v3is used, given that we should be releasing a new version of the action after this PR is merged.