Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: Add a GUI-providing plugin #562

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Mar 27, 2023

Recreation of #507 against the current main branch.

I cherry-picked the single commit of #507 onto the main branch, fixed up conflicts, and then applied style fixes.

Original description from @corranwebster:

This is a proof-of-concept which follows from some discussions about disentangling the GUI and SplashScreen objects: when using the SplashScreen support in a GUI object it requires very early creation of the GUI object, when it is really only needed at during the run method.

This shows how once this separation is done, the GUI object can be supplied by a plugin, and demonstrates use with the GUIApplication and TasksApplication classes and corresponding examples.

This attempts to be backwards compatible with existing code that (a) supplies a GUI directly and/or SplashScreen directly, or (b) relies on a default GUI and also doesn't know about GUIPlugin.

No tests right now, although existing tests might pass (it would be good if they did).

@mdickinson mdickinson marked this pull request as draft March 27, 2023 10:35
@mdickinson mdickinson changed the title Experiment: Add a GUI-providing plugin (bis) Experiment: Add a GUI-providing plugin Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants