Port Workbench from Pyface to Apptools
#331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently not working with an actual toolkit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a move of the workbench code from Pyface to Apptools. The top-level changes are:
pyface.workbench->apptools.workbenchpyface.ui.*.workbench->apptools.workbench.ui.*(I could be talked into justapptools.workbench.*like TraitsUI)examples.workbenchin Pyface repo added toexamples.workbenchin this repoToolkit management is done by using a
pyface.base_toolkit.Toolkitwith the name derived from thepyface.toolkit.toolkit(which handles toolkit selection) and pointing at the appropriate subpackage.This doesn't attempt to do anything to the Workbench code in Envisage. There is an argument it should be in here as well. We have circular dependencies between the two libraries, and it's not clear which should be "lower-level"
Other than that, changes are around import targets and a little bit of delayed importing because I was seeing circular imports after applying isort...
Checklist