Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-1063: Added a QA sampler for Spotlight.focus with preventScroll option #1697

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

0x64
Copy link
Member

@0x64 0x64 commented Sep 24, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Spotlight.focus supports preventScroll option from enactjs/enact#3277. It looks better to add a sampler case to test this API in Sandstone.

Resolution

A new sampler case is created to compare behaviors with preventScroll option and without preventScroll option.

Additional Considerations

Links

WRR-1063
enactjs/enact#3277

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])

…l` option

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.93%. Comparing base (1595503) to head (1c6c164).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1697      +/-   ##
===========================================
+ Coverage    80.83%   80.93%   +0.09%     
===========================================
  Files          148      148              
  Lines         6685     6704      +19     
  Branches      1990     1992       +2     
===========================================
+ Hits          5404     5426      +22     
+ Misses         972      970       -2     
+ Partials       309      308       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants