-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRR-1063: Added a QA sampler for Spotlight.focus
with preventScroll
option
#1697
Open
0x64
wants to merge
5
commits into
develop
Choose a base branch
from
feature/WRR-1063
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l` option Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1697 +/- ##
===========================================
+ Coverage 80.83% 80.93% +0.09%
===========================================
Files 148 148
Lines 6685 6704 +19
Branches 1990 1992 +2
===========================================
+ Hits 5404 5426 +22
+ Misses 972 970 -2
+ Partials 309 308 -1 ☔ View full report in Codecov by Sentry. |
MikyungKim
reviewed
Oct 30, 2024
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
MikyungKim
reviewed
Nov 26, 2024
MikyungKim
reviewed
Nov 26, 2024
MikyungKim
reviewed
Nov 26, 2024
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
MikyungKim
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Spotlight.focus
supportspreventScroll
option from enactjs/enact#3277. It looks better to add a sampler case to test this API in Sandstone.Resolution
A new sampler case is created to compare behaviors with
preventScroll
option and withoutpreventScroll
option.Additional Considerations
Links
WRR-1063
enactjs/enact#3277
Comments
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])