WRR-11077: Fixed Scroller to prevent the native scrolling behavior caused by keydown events when the popup is opened

[juwonjeong]

Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])

Checklist

• I have read and understand the contribution guide
• A CHANGELOG entry is included
• At least one test case is included for this feature or bug fix
• Documentation was added or is not needed
• This is an API breaking change

Issue Resolved / Feature Added

In this case, the Scroller has a button that opens FixedPopupPanel. The issue is that when press the down key at the moment the popup is opened, the scroller behind the FixedPopupPanel scrolls down.

Resolution

To fix this issue, we have to prevent the native scrolling behavior caused by keydown events.
So I fixed keydown handler of scrollerContainer to call preventDefault when a keydown event is caused by a directional key and the spotlight is paused.
To not to have spotlight dependency, the preventing function resides in sandstone and enact/Scroller just calls the funcion passed by prop like other cases.

Additional Considerations

Links

WRR-11077

Comments

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.29%. Comparing base (b2fc7be) to head (dafced6).

Files with missing lines	Patch %	Lines
packages/ui/useScroll/useScroll.js	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3297      +/-   ##
===========================================
- Coverage    82.30%   82.29%   -0.01%     
===========================================
  Files          152      152              
  Lines         7091     7093       +2     
  Branches      1867     1867              
===========================================
+ Hits          5836     5837       +1     
- Misses         985      986       +1     
  Partials       270      270              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MikyungKim]

LGTM