-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRR-287: Update the minimum supported versions of browsers #3295
base: develop
Are you sure you want to change the base?
Conversation
…aries' changes on custom skin Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
To support relative RGB, the minimum versions of browsers are updated as follows: - safari: 16.4 (note that the first fully supported version is 18.0) - chrome: 119 - firefox: 128 Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3295 +/- ##
===========================================
+ Coverage 82.30% 82.31% +0.01%
===========================================
Files 152 152
Lines 7091 7091
Branches 1867 1867
===========================================
+ Hits 5836 5837 +1
+ Misses 985 984 -1
Partials 270 270 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])
Based on MDN, safari 16.4 supports relative RGB partially.
Did you know that? |
MDN explains like below.
CanIUse (https://caniuse.com/?search=relative%20RGB) explains like below.
From the webkit bug link https://webkit.org/b/267647, we can find several facts.
Actually, relative RGB spec is changed before becoming the official standard, so Safari's implementation from 16.4 before 18.0 is based on the old spec. That is why it has an issue. So, for us, it does not matter since we simply use R,G,B value as derived without any additional calculation. If we need to calculate later, the supported version of Safari needs to be updated at least 18.0 or higher after testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
Issue Resolved / Feature Added
Along with theme library's change, the minimum version of browsers need to be updated and our documents also need to be updated.
In detail, we start to use relative RGB that is supported from safari 16.4, chrome 119, and firefox 128.
Resolution
Additional Considerations
Links
WRR-287
Comments
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek ([email protected])