Display reviews count on teams main page #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking up the join directly is a bit cheaper, and we only need to do it if we have specified that we want review data.
|
Thanks @Poslovitch. I've pushed a commit which should preserve functionality and simplify a bit by looking up the join relationship directly. (Doing a full join on all reviews for every team instantiation is potentially a bit expensive.) Let me know if that works for you as expected (it does for me) and I can merge. I've also changed it from |
|
Thanks @eloquence ! It works on my end as well. I'm glad to see there's a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #199
Would happily get some feedback on this one, before I start doing it for the user and thing pages. :)