Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CI #306

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Simplify CI #306

merged 5 commits into from
Jun 18, 2024

Conversation

whatyouhide
Copy link
Member

WIP.

@whatyouhide
Copy link
Member Author

@josevalim looks like in OTP 26 there's a change with the return value for GenServer.init/1. It doesn't seem to exit anymore? See the CI failure.

I’m out of a it a bit so this might be well known, but it surprised me. Might be this, I think?

Anyway, maybe we just remove the assertion on those or scope it down to OTP <= 25?

@josevalim
Copy link
Member

@whatyouhide they changed the meaning of {:error, _} and/or failures inside GenServer.init. I think having a conditional test is indeed better.

@whatyouhide
Copy link
Member Author

@josevalim yeah what's weird is that they say that returning {:error, _} (which is a new possible return value in OTP 26) catches the :EXIT message, but returning {:stop, _} should behave like before. I’m sure I’m misinterpreting the docs, but anyway yeah sounds good!

@whatyouhide whatyouhide marked this pull request as ready for review June 18, 2024 15:54
@whatyouhide
Copy link
Member Author

The failing test is a flaky test that's been around for a while, I will look into it separately.

@whatyouhide whatyouhide merged commit f2ce356 into main Jun 18, 2024
1 of 3 checks passed
@whatyouhide whatyouhide deleted the al/ci branch June 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants