Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to GTK4 #579

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Port to GTK4 #579

wants to merge 9 commits into from

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Sep 17, 2024

This should work now.

Todo:

  • window drag doesn't work on X11 (i'd like to treat this as not blocking because I'm not quite sure what's going on here and kinda consider X11 only legacy anyways but idk)
  • The transparency doesn't fully work (probably a CSS issue idk)

Misc:

  • We get a warning about gtk_is_ancestor receiving null everytime an indicator is opened but idk why and wouldn't consider it blocking i guess?

@leolost2605 leolost2605 marked this pull request as ready for review September 18, 2024 15:07
@danirabbit
Copy link
Member

I think probably the best way forward for development is I can create a new packaging branch based on this branch and then build that in daily so we can start building indicators against it etc

But I'm not sure what trying to upgrade this mid-cycle looks like, so I'd like to leave it unmerged for now until we have a plan around how to handle the packaging/upgrade.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update deps on README and .github :)

@danirabbit
Copy link
Member

There's a packaging branch now: https://github.com/elementary/wingpanel/tree/deb-packaging-gtk4

So we should have access to the library on OS 8 daily no problem to work with porting the other indicators when this builds: https://code.launchpad.net/~elementary-os/+recipe/wingpanel-8-daily

You might want to temporarily change the meson project name here to io.elementary.wingpanel-8 or something so that you can install them both at the same time for testing? Otherwise the io.elementary.wingpanel-8 package will refuse to install because of the file conflicts. But this package name will eventually be reverted anyways so that's optional I guess 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants