Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopoverManager: simplify make_modal #525

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Mar 9, 2024

No description provided.

@lenemter lenemter requested a review from a team March 9, 2024 12:16
@jeremypw
Copy link
Collaborator

jeremypw commented Mar 9, 2024

The code is OK but I don't really understand the purpose of this function tbh - can't the popover modal property just be set? It will have to be rewritten for Gtk4 anyway as there is no grabbing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants