Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rfkill bus #129

Closed
wants to merge 2 commits into from
Closed

Rfkill bus #129

wants to merge 2 commits into from

Conversation

torikulhabib
Copy link
Contributor

I think this method works on my device hopefully as expected.
please comment if something goes wrong
#61

@tintou
Copy link
Member

tintou commented Sep 24, 2020

Thanks for this patch, bu I don't think that we should go this route of doing everything manually in the indicator and plug.
The GNOME Settings Daemon already provides an interface on the session bus org.gnome.SettingsDaemon.Rfkill, we should start using it as it would allow us to have the state synced across all the components without much hassle.

@torikulhabib
Copy link
Contributor Author

previously I used the dbus method calling org.gnome.SettingsDaemon.Rfkill then I kept trying for a few weeks, at one point I tried to turn on and off the org.gnome.SettingsDaemon.Rfkill bluetooth not responding. and when using this method it works well. I think elementary has to start building its own bus so I created this branch.

@danirabbit
Copy link
Member

It seems like #102 is using GSD as expected, so I'm going to close this branch as "Design conflict" in favor of the other

@danirabbit danirabbit closed this Apr 6, 2021
@danirabbit danirabbit added the Design Conflict Conflicts with the intended scope or design label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Conflict Conflicts with the intended scope or design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants