Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix muting outputs #261

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix muting outputs #261

merged 1 commit into from
Jan 24, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jan 24, 2024 •
edited
Loading

Fixes #260
source_name is only provided and needed for sources. Same with sink_name. Therefore move the null checks to where they are actually needed.

@leolost2605 leolost2605 requested a review from a team January 24, 2024 16:17
jeremypw
jeremypw approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@jeremypw jeremypw merged commit fe0a776 into main Jan 24, 2024
3 of 4 checks passed
@jeremypw jeremypw deleted the fix-mute branch January 24, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gtk4: Toggling mute switch does nothing
2 participants
@leolost2605 @jeremypw