Disable content grid child switches when service switch is off #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is intentional. By not changing the state of child switches when the service switch turns off, users can restore their customized sharing setting just by turning on the service switch again. |
|
I updated the PR description to include the issue link. If as @ryonakano suggested that we wanted to preserve the user's sharing settings, as an alternative we could just hide the content-grid when the service is disabled. |
|
@tjchester Thank you for quoting the issue link! We seem to need some discussion about the design. |
|
@tjchester Closing as has unaddressed issues and no recent activity. Please feel free to reopen (as draft) if you wish to continue working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1 - Change all child switches to off when parent switch is off