Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/Hide job queue according to privacy setting #161

Closed
wants to merge 1 commit into from
Closed

Show/Hide job queue according to privacy setting #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 54 additions & 11 deletions src/Views/JobsView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,35 @@
*/

public class Printers.JobsView : Gtk.Frame {
private Printer printer;
private const string PRIVACY_KEY = "remember-recent-files";
private Gtk.ListBox list_box;
private Granite.Widgets.AlertView empty_alert;
private Granite.Widgets.AlertView privacy_alert;

public Settings gnome_privacy_settings { get; construct; }
public Printer printer { get; construct; }

public JobsView (Printer printer) {
this.printer = printer;
Object (printer: printer);
}

construct {
empty_alert = new Granite.Widgets.AlertView (
_("Print Queue Is Empty"),
_("There are no pending jobs in the queue."),
""
);
empty_alert.show_all ();

var alert = new Granite.Widgets.AlertView (_("Print Queue Is Empty"), _("There are no pending jobs in the queue."), "");
alert.show_all ();
privacy_alert = new Granite.Widgets.AlertView (
_("Print History Is Inaccessible"),
_("The Privacy settings do not permit the job queue to be shown"),
""
);
privacy_alert.show_all ();

list_box = new Gtk.ListBox ();
list_box.selection_mode = Gtk.SelectionMode.SINGLE;
list_box.set_placeholder (alert);
list_box.set_header_func ((Gtk.ListBoxUpdateHeaderFunc) update_header);
list_box.set_sort_func ((Gtk.ListBoxSortFunc) compare);

Expand All @@ -41,15 +58,26 @@ public class Printers.JobsView : Gtk.Frame {
scrolled.add (list_box);
scrolled.show_all ();

var jobs = printer.get_jobs (true, CUPS.WhichJobs.ALL);
foreach (var job in jobs) {
list_box.add (new JobRow (printer, job));
}

add (scrolled);

gnome_privacy_settings = new Settings ("org.gnome.desktop.privacy");
gnome_privacy_settings.changed.connect ((key) => {
if (key == PRIVACY_KEY) {
update_privacy ();
}
});

update_privacy ();

unowned Cups.Notifier notifier = Cups.Notifier.get_default ();
notifier.job_created.connect ((text, printer_uri, name, state, state_reasons, is_accepting_jobs, job_id, job_state, job_state_reason, job_name, job_impressions_completed) => {
notifier.job_created.connect (
(text, printer_uri, name, state, state_reasons, is_accepting_jobs,
job_id, job_state, job_state_reason, job_name, job_impressions_completed) => {

if (!gnome_privacy_settings.get_boolean (PRIVACY_KEY)) {
return;
}

if (printer.dest.name != name) {
return;
}
Expand All @@ -70,6 +98,21 @@ public class Printers.JobsView : Gtk.Frame {
return timeb.compare (timea);
}

private void update_privacy () {
if ( gnome_privacy_settings.get_boolean (PRIVACY_KEY)) {
list_box.set_placeholder (empty_alert);
var jobs = printer.get_jobs (true, CUPS.WhichJobs.ALL);
foreach (var job in jobs) {
list_box.add (new JobRow (printer, job));
}
} else {
list_box.foreach ((row) => {
list_box.remove (row);
});
list_box.set_placeholder (privacy_alert);
}
}

[CCode (instance_pos = -1)]
private void update_header (JobRow row1, JobRow? row2) {
if (row1.job.cjob.state == CUPS.IPP.JobState.COMPLETED && (row2 == null || row1.job.cjob.state != row2.job.cjob.state)) {
Expand Down