Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UbuntuInstaller: get permission async #214

Merged
merged 12 commits into from
Jun 29, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jun 18, 2024

Fixes #112
Fixes #204

@danirabbit danirabbit changed the title Danirabbit/installer asyncpermissions UbuntuInstaller: get permission async Jun 18, 2024
@danirabbit danirabbit force-pushed the danirabbit/installer-asyncpermissions branch from fa720a5 to 818c316 Compare June 18, 2024 22:57
@danirabbit danirabbit requested a review from a team June 18, 2024 22:57
@danirabbit danirabbit marked this pull request as ready for review June 18, 2024 22:57
src/Installer/UbuntuInstaller.vala Outdated Show resolved Hide resolved
src/Installer/UbuntuInstaller.vala Outdated Show resolved Hide resolved
danirabbit and others added 2 commits June 21, 2024 18:53
@ryonakano

This comment was marked as resolved.

@danirabbit
Copy link
Member Author

Oops I thought I got them all. Will fix!

@danirabbit danirabbit requested a review from ryonakano June 25, 2024 21:29
@danirabbit
Copy link
Member Author

@ryonakano should be fixed now!

@danirabbit danirabbit requested a review from ryonakano June 27, 2024 19:29
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected!

@ryonakano ryonakano merged commit 1d87c96 into main Jun 29, 2024
2 of 4 checks passed
@ryonakano ryonakano deleted the danirabbit/installer-asyncpermissions branch June 29, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants