Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocaleSetting: add option for auto temp unit #213

Merged
merged 4 commits into from
Jun 22, 2024
Merged

LocaleSetting: add option for auto temp unit #213

merged 4 commits into from
Jun 22, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jun 18, 2024 •
edited
Loading

Fixes #81

AFTER

Screenshot from 2024-06-18 10 15 21

BEFORE

Screenshot from 2024-06-18 10 17 26

@danirabbit danirabbit requested a review from a team June 18, 2024 17:17
ryonakano
ryonakano approved these changes Jun 22, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected.

@ryonakano ryonakano enabled auto-merge (squash) June 22, 2024 02:13
@ryonakano ryonakano merged commit e89970d into main Jun 22, 2024
2 of 4 checks passed
@ryonakano ryonakano deleted the danirabbit/localesetting-autotemp branch June 22, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting default temperature units depending on locale
3 participants
@danirabbit @ryonakano @zeebok