Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: Don't trim language codes #156

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Conversation

davidmhewitt
Copy link
Member

We cannot assume that language codes will be 2 characters long. This prevents the installation and removal of languages that have 3 letter codes and/or additional variants.

To test:

  • With master, try installing the "Tatar, Crimean" (crh) language.
  • Note that no progress indicator appears, and the language is not available after "installation". There is another bug that prevents the list updating after changes (Installed Languages list does not refresh on changes #149), but even after a restart of the plug, "Tatar, Crimean" will not be available.
  • Install this branch and try again.
  • Note that the progress window does indeed appear this time
  • After a restart of the plug, the language should be available.

@ryonakano
Copy link
Contributor

Screenshot after installing and setting Central Kurdish as the system language with this branch:

Screenshot from 2022-04-12 20-44-59

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works confirmed with installation/removal of Central Kurdish (ckb) and Japanese (ja), no regressions found. Thank you very much!

@ryonakano ryonakano merged commit 04ccae0 into master Apr 12, 2022
@ryonakano ryonakano deleted the installer-remove-substring branch April 12, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants